On 20-08-19, 19:03, Amit Kucheria wrote:
> On Tue, Aug 20, 2019 at 12:14 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> >
> > This add base DTS file with cpu, psci, firmware, clock, tlmm and
> > spmi nodes which enables boot to console
> >
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/sm8150.dtsi | 305 +++++++++++++++++++++++++++
> > 1 file changed, 305 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/sm8150.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > new file mode 100644
> > index 000000000000..d9dc95f851b7
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > @@ -0,0 +1,305 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
>
> This is fine.
>
> > +// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
> > +// Copyright (c) 2019, Linaro Limited
>
> These two lines should be in /* */
Yeah I made it same as previous, lets do right style.
> > + timer {
> > + compatible = "arm,armv8-timer";
> > + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
>
> Any particular reason why these are defined in this order - 1, 2, 3, 0?
Copied from downstream :)
--
~Vinod
