Hi Laurent, Thank you for your feedback! > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Sent: 15 August 2019 12:47 > Subject: Re: [PATCH v2 2/9] dt-bindings: display: Add bindings for Advantech IDK-2121WR > > Hi Fabrizio, > > On Thu, Aug 15, 2019 at 12:04:26PM +0100, Fabrizio Castro wrote: > > This panel is handled through the generic lvds-panel bindings, > > so only needs its additional compatible specified. > > > > Some panel-specific documentation can be found here: > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > > > --- > > v1->v2: > > * Reworked according to Laurent's feedback > > * Renamed lvds0_panel_in to panel_in0 > > * Renamed lvds1_panel_in to panel_in1 > > > > Laurent, > > > > Should this be a .yaml file already? > > It's not a strict requirement, but I'm sure Rob would really appreciate. > I've converted a DT binding to yaml recently (for a panel too), and I > have to say I'm impressed by the validation yaml brings, both for DT > sources and for DT bindings. It even validates the example in the > bindings, which is great. Documentation/devicetree/writing-schema.md > should give you a few pointers to get started (in particular make sure > you run make dt_binding_check for your new bindings). Will give this a try. Thanks, Fab > > > .../display/panel/advantech,idk-2121wr.txt | 56 ++++++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > > > > diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > > new file mode 100644 > > index 0000000..6ee1d1b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > > @@ -0,0 +1,56 @@ > > +Advantech Co., Ltd. IDK-2121WR 21.5" LVDS panel > > +=============================================== > > + > > +Required properties: > > +- compatible: should be "advantech,idk-2121wr" followed by "panel-lvds" > > + > > +This binding is compatible with the lvds-panel binding, which is specified > > +in panel-lvds.txt in this directory. > > +The panel operates in dual-link mode and thus requires two port nodes, > > +the first port node expects odd pixels (1, 3, 5, etc.) and the second port > > +expects even pixels (0, 2, 4, etc.). > > + > > +Example > > +------- > > + > > + panel { > > + compatible = "advantech,idk-2121wr", "panel-lvds"; > > + > > + width-mm = <476>; > > + height-mm = <268>; > > + > > + data-mapping = "vesa-24"; > > + > > + panel-timing { > > + clock-frequency = <148500000>; > > + hactive = <1920>; > > + vactive = <1080>; > > + hsync-len = <44>; > > + hfront-porch = <88>; > > + hback-porch = <148>; > > + vfront-porch = <4>; > > + vback-porch = <36>; > > + vsync-len = <5>; > > + }; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + /* Odd pixels */ > > + reg = <0>; > > + panel_in0: endpoint { > > + remote-endpoint = <&lvds0_out>; > > + }; > > + }; > > + > > + port@1 { > > + /* Even pixels */ > > + reg = <1>; > > + panel_in1: endpoint { > > + remote-endpoint = <&lvds1_out>; > > + }; > > + }; > > + }; > > + }; > > -- > > 2.7.4 > > > > -- > Regards, > > Laurent Pinchart
