Hi Tushar, Thank you for the review. On Tue, Apr 22, 2014 at 11:13 AM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote: > On 20 April 2014 10:56, Arun Kumar K <arun.kk@xxxxxxxxxxx> wrote: >> Adds the google peach-pit board dts file which uses >> exynos5420 SoC. >> >> Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx> >> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 225 ++++++++++++++++++++++++++++ >> 2 files changed, 226 insertions(+) >> create mode 100644 arch/arm/boot/dts/exynos5420-peach-pit.dts >> > > [ snip ] > >> + pinctrl@13400000 { >> + lid_irq: lid-irq { >> + samsung,pins = "gpx3-4"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> + >> + power_key_irq: power-key-irq { >> + samsung,pins = "gpx1-2"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> + >> + tpm_irq: tpm-irq { >> + samsung,pins = "gpx1-0"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> + }; >> + > > If you plan to respin, please consider keeping the above entries > sorted based on the pin numbers. > > tpm_irq > power_key_irq > lid_irq > Ok will change the order Regards Arun > > -- > Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html