On Tue, Aug 6, 2019 at 4:04 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > On Tue, Aug 6, 2019 at 2:27 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > > > > On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > > > > PowerPC platforms don't use the generic of/platform code to populate the > > > devices from DT. > > > > Yes, they do. > > No they don't. My wording could be better, but they don't use > of_platform_default_populate_init() > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/of/platform.c#n511 Right, but the rest of the of/platform code is used (guess where it got moved here from?). > > > Therefore the generic device linking code is never used > > > in PowerPC. Compile it out to avoid warning about unused functions. > > > > I'd prefer this get disabled on PPC using 'if (IS_ENABLED(CONFIG_PPC)) > > return' rather than #ifdefs. > > I'm just moving the existing ifndef some lines above. I don't want to > go change existing #ifndef in this patch. Maybe that should be a > separate patch series that goes and fixes all such code in drivers/of/ > or driver/ So the initcall was originally just supposed to call of_platform_default_populate(), but it's grown beyond that. That could make things fragile as it is possible for platforms to call of_platform_populate() (directly or indirectly) before of_platform_default_populate_init(). That was supposed to work, but now I think it's getting more fragile. Anyways, I guess this patch is fine for now. Rob
