On 8/14/19 9:46 PM, Oleh Kravchenko wrote: > Hello Jacek, > > 14.08.19 21:18, Jacek Anaszewski пише: >>>> Why the sequence "1 800 2 800 4 800 8 800 16 800" is duplicated here? >>>> It seems redundant. But aside of that - aren't the timings modifiable? >>>> In other words - are these all patterns somehow configurable or they are >>>> pre-programmed? >>>> >>> >>> All pattern is predefined, you can't change them at all. >>> I just tried to describe real things what happened in LED board. >>> It's ticks every 800 milliseconds for Pipe LEDs. >> >> It makes me wonder how you figured out the values? If you have >> a documentation for this controller, could you share how the pattern >> settings are documented? > > I saw the code of firmware. > Not sure if I can find any documentation for it right now. Have you tried to alter the values? Or check what happens when the duplication is removed? >>>>> + >>>>> + Inverted cascade mode for Pipe LED: >>>>> + "30 800 29 800 27 800 23 800 15 800 30 800 29 800 27 800 23 800 15 800" >>>> >>>> Similar duplication here. >>>> >>>>> + >>>>> + Bounce mode for Pipe LED: >>>>> + "1 800 2 800 4 800 8 800 16 800 16 800 8 800 4 800 2 800 1 800" >>>> >>>> Instead of two repeating "16 800" you could provide "16 1600". >>>> But here again is the question whether these values are configurable. >>>> From what I can see in your driver implementation you're expecting >>>> exactly the values provided in these examples to enable given hardware >>>> pattern (led_pattern_cmp()). >>>> >>>>> + >>>>> + Inverted bounce mode for Pipe LED: >>>>> + "30 800 29 800 27 800 23 800 15 800 15 800 23 800 27 800 29 800 30 800" >>>> >>> >>> Should I cut this patterns to smaller? Or let keep it? >>> >> >> For the first two we could do without sequence duplication. > > Ok, I will reduce it. Please hold on for a while. I will have some more remarks to the driver, just collecting missing info for now to gain more complete view on this device. -- Best regards, Jacek Anaszewski
