On 8/12/2019 4:23 AM, Alexandru Ardelean wrote: > The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into > a low power mode when there is no signal on the wire (typically cable > unplugged). > This behavior is enabled by default, but can be disabled via device > property. We could consider adding a PHY tunable, having this as a Device Tree property amounts to putting a policy inside DT, which is frowned upon. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> Other than that, the code looks fine: Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> -- Florian