Hi Uwe, On Fri, 9 Aug 2019 at 18:06, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote: > > Hi Uwe, > > On Fri, 9 Aug 2019 at 17:10, Uwe Kleine-König > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > > On Thu, Aug 08, 2019 at 04:59:39PM +0800, Baolin Wang wrote: > > > From: Neo Hou <neo.hou@xxxxxxxxxx> > > > > > > This patch adds the Spreadtrum PWM support, which provides maximum 4 > > > channels. > > > > > > Signed-off-by: Neo Hou <neo.hou@xxxxxxxxxx> > > > Co-developed-by: Baolin Wang <baolin.wang@xxxxxxxxxx> > > > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> > > > --- > > > drivers/pwm/Kconfig | 10 ++ > > > drivers/pwm/Makefile | 1 + > > > drivers/pwm/pwm-sprd.c | 311 ++++++++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 322 insertions(+) > > > create mode 100644 drivers/pwm/pwm-sprd.c > > > > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > > > index a7e5751..4963b4d 100644 > > > --- a/drivers/pwm/Kconfig > > > +++ b/drivers/pwm/Kconfig > > > @@ -423,6 +423,16 @@ config PWM_SPEAR > > > To compile this driver as a module, choose M here: the module > > > will be called pwm-spear. > > > > > > +config PWM_SPRD > > > + tristate "Spreadtrum PWM support" > > > + depends on ARCH_SPRD || COMPILE_TEST > > > > I think you need > > > > depends on HAS_IOMEM > > OK. > > > > > > + help > > > + Generic PWM framework driver for the PWM controller on > > > + Spreadtrum SoCs. > > > + > > > + To compile this driver as a module, choose M here: the module > > > + will be called pwm-sprd. > > > + > > > config PWM_STI > > > tristate "STiH4xx PWM support" > > > depends on ARCH_STI > > > diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile > > > index 76b555b..26326ad 100644 > > > --- a/drivers/pwm/Makefile > > > +++ b/drivers/pwm/Makefile > > > @@ -41,6 +41,7 @@ obj-$(CONFIG_PWM_ROCKCHIP) += pwm-rockchip.o > > > obj-$(CONFIG_PWM_SAMSUNG) += pwm-samsung.o > > > obj-$(CONFIG_PWM_SIFIVE) += pwm-sifive.o > > > obj-$(CONFIG_PWM_SPEAR) += pwm-spear.o > > > +obj-$(CONFIG_PWM_SPRD) += pwm-sprd.o > > > obj-$(CONFIG_PWM_STI) += pwm-sti.o > > > obj-$(CONFIG_PWM_STM32) += pwm-stm32.o > > > obj-$(CONFIG_PWM_STM32_LP) += pwm-stm32-lp.o > > > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > > > new file mode 100644 > > > index 0000000..f6fc793 > > > --- /dev/null > > > +++ b/drivers/pwm/pwm-sprd.c > > > @@ -0,0 +1,311 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2019 Spreadtrum Communications Inc. > > > > If there is a publicly available reference manual available, please add > > a link to it here. > > Sure. Sorry, we have not supplied a publicly available reference manual now. So no change for this comment in next version. -- Baolin Wang Best Regards
