Hi Rob, On Mon, Aug 12, 2019 at 01:18:39PM -0600, Rob Herring wrote: > On Sat, Aug 10, 2019 at 5:10 PM Laurent Pinchart wrote: > > > > The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB > > parallel data interface and an SPI control interface. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > Changes since v1: > > > > - Convert to YAML > > --- > > .../display/panel/nec,nl8048hl11.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml > > new file mode 100644 > > index 000000000000..cc3d40975828 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NEC NL8048HL11 4.1" WVGA TFT LCD panel > > + > > +description: > > + The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel > > + data interface and an SPI control interface. > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: nec,nl8048hl11 > > + > > + label: true > > + reset-gpios: true > > + port: true > > + > > +required: > > + - compatible > > + - reset-gpios > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > Your example will fail on 'make dt_binding_check'... I wasn't aware of this. I've now read writing-schema.md and will make sure to submit bindings that pass the checks. I'll address the issues your pointed out below for the next version. > > + - | > > + lcd_panel: panel { > > SPI devices have to have a minimal SPI controller parent. Primarily > just #size-cells and #address-cells are needed. > > 'reg' is missing here too. > > > + compatible = "nec,nl8048hl11"; > > + spi-max-frequency = <10000000>; > > This needs to be listed in properties ideally with some constraints. > > > + > > + reset-gpios = <&gpio7 7 GPIO_ACTIVE_LOW>; > > And GPIO_ACTIVE_LOW. You have to add includes you need. > > > + > > + port { > > + lcd_in: endpoint { > > + remote-endpoint = <&dpi_out>; > > + }; > > + }; > > + }; > > + > > +... -- Regards, Laurent Pinchart
