Quoting Brendan Higgins (2019-08-12 11:24:17) > diff --git a/arch/um/configs/kunit_defconfig b/arch/um/configs/kunit_defconfig > new file mode 100644 > index 0000000000000..bfe49689038f1 > --- /dev/null > +++ b/arch/um/configs/kunit_defconfig > @@ -0,0 +1,8 @@ > +CONFIG_OF=y > +CONFIG_OF_UNITTEST=y > +CONFIG_OF_OVERLAY=y > +CONFIG_I2C=y > +CONFIG_I2C_MUX=y > +CONFIG_KUNIT=y > +CONFIG_KUNIT_TEST=y > +CONFIG_KUNIT_EXAMPLE_TEST=y > diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config > new file mode 100644 > index 0000000000000..bfe49689038f1 > --- /dev/null > +++ b/tools/testing/kunit/configs/all_tests.config > @@ -0,0 +1,8 @@ > +CONFIG_OF=y > +CONFIG_OF_UNITTEST=y > +CONFIG_OF_OVERLAY=y > +CONFIG_I2C=y > +CONFIG_I2C_MUX=y Are these above config options necessary? I don't think they're part of the patch series anymore so it looks odd to enable the OF unittests and i2c configs. > +CONFIG_KUNIT=y > +CONFIG_KUNIT_TEST=y > +CONFIG_KUNIT_EXAMPLE_TEST=y