Hi Andrew, Thanks a lot for your review! Regards, Zhiqiang > -----Original Message----- > From: Andrew Murray <andrew.murray@xxxxxxx> > Sent: 2019年8月12日 16:36 > To: Z.q. Hou <zhiqiang.hou@xxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; gustavo.pimentel@xxxxxxxxxxxx; > jingoohan1@xxxxxxxxx; bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; Leo Li > <leoyang.li@xxxxxxx>; lorenzo.pieralisi@xxxxxxx; M.h. Lian > <minghuan.lian@xxxxxxx> > Subject: Re: [PATCH 4/4] arm64: dts: fsl: Remove num-lanes property from > PCIe nodes > > On Mon, Aug 12, 2019 at 04:22:33AM +0000, Z.q. Hou wrote: > > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > > > > On FSL Layerscape SoCs, the number of lanes assigned to PCIe > > controller is not fixed, it is determined by the selected SerDes > > protocol in the RCW (Reset Configuration Word), and the PCIe link > > training is completed automatically base on the selected SerDes > > protocol, and the link width set-up is updated by hardware. So the > > num-lanes is not needed to specify the link width. > > > > The current num-lanes indicates the max lanes PCIe controller can > > support up to, instead of the lanes assigned to the PCIe controller. > > This can result in PCIe link training fail after hot-reset. So remove > > the num-lanes to avoid set-up to incorrect link width. > > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 - > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 --- > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ------ > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 3 --- > > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 4 ---- > > 5 files changed, 17 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > index ec6257a5b251..119c597ca867 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > @@ -486,7 +486,6 @@ > > #address-cells = <3>; > > #size-cells = <2>; > > device_type = "pci"; > > - num-lanes = <4>; > > num-viewport = <2>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > index 71d9ed9ff985..c084c7a4b6a6 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > @@ -677,7 +677,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -704,7 +703,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <2>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x48 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -731,7 +729,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <2>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x50 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > index b0ef08b090dd..d4c1da3d4bde 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > @@ -649,7 +649,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <8>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -671,7 +670,6 @@ > > reg-names = "regs", "addr_space"; > > num-ib-windows = <6>; > > num-ob-windows = <8>; > > - num-lanes = <2>; > > status = "disabled"; > > }; > > > > @@ -687,7 +685,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <2>; > > num-viewport = <8>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x48 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -709,7 +706,6 @@ > > reg-names = "regs", "addr_space"; > > num-ib-windows = <6>; > > num-ob-windows = <8>; > > - num-lanes = <2>; > > status = "disabled"; > > }; > > > > @@ -725,7 +721,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <2>; > > num-viewport = <8>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x50 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -747,7 +742,6 @@ > > reg-names = "regs", "addr_space"; > > num-ib-windows = <6>; > > num-ob-windows = <8>; > > - num-lanes = <2>; > > status = "disabled"; > > }; > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > index dfbead405783..76c87afeba1e 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > @@ -456,7 +456,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <256>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x20 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -482,7 +481,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x28 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > @@ -508,7 +506,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <8>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > ranges = <0x81000000 0x0 0x00000000 0x30 0x00010000 0x0 > 0x00010000 /* downstream I/O */ > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > > index 64101c9962ce..7a0be8eaa84a 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > > @@ -639,7 +639,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > msi-parent = <&its>; > > @@ -661,7 +660,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > msi-parent = <&its>; > > @@ -683,7 +681,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <8>; > > num-viewport = <256>; > > bus-range = <0x0 0xff>; > > msi-parent = <&its>; > > @@ -705,7 +702,6 @@ > > #size-cells = <2>; > > device_type = "pci"; > > dma-coherent; > > - num-lanes = <4>; > > num-viewport = <6>; > > bus-range = <0x0 0xff>; > > msi-parent = <&its>; > > Reviewed-by: Andrew Murray <andrew.murray@xxxxxxx> > > > -- > > 2.17.1 > >
