On Mon, Aug 12, 2019 at 12:49 PM Leonard Crestez <leonard.crestez@xxxxxxx> wrote: > > Add initial dt bindings for the interconnects inside i.MX chips. > Multiple external IPs are involved but SOC integration means the > software controllable interfaces are very similar. > > This is initially only for imx8mm but add an "fsl,imx8m-nic" fallback > similar to exynos-bus. > > Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx> > --- > .../devicetree/bindings/devfreq/imx.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/imx.yaml > > diff --git a/Documentation/devicetree/bindings/devfreq/imx.yaml b/Documentation/devicetree/bindings/devfreq/imx.yaml > new file mode 100644 > index 000000000000..0e2ee3a5205e > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/imx.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/devfreq/imx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic i.MX bus frequency device > + > +maintainers: > + - Leonard Crestez <leonard.crestez@xxxxxxx> > + > +description: | > + The i.MX SoC family has multiple buses for which clock frequency (and sometimes > + voltage) can be adjusted. > + > + Some of those buses expose register areas mentioned in the memory maps as GPV > + ("Global Programmers View") but not all. Access to this area might be denied for > + normal world. > + > + The buses are based on externally licensed IPs such as ARM NIC-301 and Arteris > + FlexNOC but DT bindings are specific to the integration of these bus > + interconnect IPs into imx SOCs. No need to use the interconnect binding? > + > +properties: > + compatible: > + contains: > + enum: > + - fsl,imx8m-noc > + - fsl,imx8m-nic This means any combination of these 2 strings is valid. I suspect you want a given node to have only one of them, so drop 'contains' > + > + reg: > + maxItems: 1 > + description: GPV area > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - clocks reg? > + > +examples: > + - | > + #include <dt-bindings/clock/imx8mm-clock.h> > + noc: noc@32700000 { > + compatible = "fsl,imx8mm-noc", "fsl,imx8m-noc"; Doesn't match the schema. (Well, it does with 'contains', but fsl,imx8mm-noc is not documented.) > + reg = <0x32700000 0x100000>; > + clocks = <&clk IMX8MM_CLK_NOC>; > + operating-points-v2 = <&noc_opp_table>; Not documented. > + }; > -- > 2.17.1 >