On Mon, 05 Aug 2019, Alexandre Belloni wrote: > On 29/07/2019 19:41:47+0200, Frank Wunderlich wrote: > > From: Josef Friedl <josef.friedl@xxxxxxxx> > > > > move code to separate header-file to reuse definitions later > > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c) > > > > changes since v2: add missing commit-message > > The changelog should be after the --- marker. > > > > Suggested-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > Signed-off-by: Josef Friedl <josef.friedl@xxxxxxxx> > > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > --- > > drivers/rtc/rtc-mt6397.c | 55 +------------------------- > > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++ I think include/linux/rtc/mt6397.h would be better? Certainly from a maintainance PoV, it would be better reviewed and looked after by an RTC expert. > > 2 files changed, 72 insertions(+), 54 deletions(-) > > create mode 100644 include/linux/mfd/mt6397/rtc.h -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
