On Thu, 2019-08-08 at 17:03 -0600, Rob Herring wrote: > [External] > > On Thu, Aug 8, 2019 at 6:31 AM Alexandru Ardelean > <alexandru.ardelean@xxxxxxxxxx> wrote: > > This change adds bindings for the Analog Devices ADIN PHY driver, detailing > > all the properties implemented by the driver. > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > --- > > .../devicetree/bindings/net/adi,adin.yaml | 76 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 77 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/adi,adin.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml > > b/Documentation/devicetree/bindings/net/adi,adin.yaml > > new file mode 100644 > > index 000000000000..86177c8fe23a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0+ > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/adi,adin.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices ADIN1200/ADIN1300 PHY > > + > > +maintainers: > > + - Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > + > > +description: | > > + Bindings for Analog Devices Industrial Ethernet PHYs > > + > > +allOf: > > + - $ref: ethernet-phy.yaml# > > + > > +properties: > > + adi,rx-internal-delay-ps: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: | > > + RGMII RX Clock Delay used only when PHY operates in RGMII mode with > > + internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds. > > + enum: [ 1600, 1800, 2000, 2200, 2400 ] > > + default: 2000 > > This doesn't actually do what you think. The '$ref' has to be under an > 'allOf' to work. It's an oddity of json-schema. However, anything with > a standard unit suffix already has a schema to define the type, so you > don't need to here and can just drop $ref. ack will drop > > > + > > + adi,tx-internal-delay-ps: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: | > > + RGMII TX Clock Delay used only when PHY operates in RGMII mode with > > + internal delay (phy-mode is 'rgmii-id' or 'rgmii-txid') in pico-seconds. > > + enum: [ 1600, 1800, 2000, 2200, 2400 ] > > + default: 2000 > > + > > + adi,fifo-depth-bits: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: | > > + When operating in RMII mode, this option configures the FIFO depth. > > + enum: [ 4, 8, 12, 16, 20, 24 ] > > + default: 8 > > + > > + adi,disable-energy-detect: > > + description: | > > + Disables Energy Detect Powerdown Mode (default disabled, i.e energy detect > > + is enabled if this property is unspecified) > > + type: boolean > > + > > +examples: > > + - | > > + ethernet { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + phy-mode = "rgmii-id"; > > + > > + ethernet-phy@0 { > > + reg = <0>; > > + > > + adi,rx-internal-delay-ps = <1800>; > > + adi,tx-internal-delay-ps = <2200>; > > + }; > > + }; > > + - | > > + ethernet { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + phy-mode = "rmii"; > > + > > + ethernet-phy@1 { > > + reg = <1>; > > + > > + adi,fifo-depth-bits = <16>; > > + adi,disable-energy-detect; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index e8aa8a667864..fd9ab61c2670 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -944,6 +944,7 @@ L: netdev@xxxxxxxxxxxxxxx > > W: http://ez.analog.com/community/linux-device-drivers > > S: Supported > > F: drivers/net/phy/adin.c > > +F: Documentation/devicetree/bindings/net/adi,adin.yaml > > > > ANALOG DEVICES INC ADIS DRIVER LIBRARY > > M: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > -- > > 2.20.1 > >
