Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> writes: > Hi Guillaume, > > On Mon, Aug 5, 2019 at 2:48 PM guillaume La Roque <glaroque@xxxxxxxxxxxx> wrote: >> >> Hi Martin, >> >> again thanks for your review. > you're welcome - thank you for working on the driver :-) > > [...] >> > The IP block has more functionality, which may be added to this driver >> > in the future: >> > - reading up to 16 stored temperature samples >> >> it's not working, you can verify it if you check the regmap define in the driver. in fact temp is only write in one register, it's confirmed by amlogic. > I missed that - so please skip this part > > [...] >> >> +config AMLOGIC_THERMAL >> > we typically use "MESON" in the Kconfig symbols: >> > $ grep -c AMLOGIC .config >> > 1 >> > $ grep -c MESON .config >> > 33 >> > >> > I also wonder if we should add G12 or G12A so we don't conflict with >> > upcoming thermal sensors with a different design (assuming that this >> > will be a thing). >> > for example we already have three different USB2 PHY drivers >> > >> > [...] >> >> i check with Neil and for new family it's better to use Amlogic instead of meson. > can you please share the considerations behind this decision? > if new drivers should use AMLOGIC_* Kconfig symbols instead of MESON_* > then we all should know about it > >> i don't add G12 because we already know it's same sensors for SM1 SoC family [0]. > my idea behind this was to avoid conflicts in the future > in case of the thermal driver we may be fine with using a generic name > assuming that Amlogic will not switch to a new IP block in the next > years > I'm not saying you have to change the name - I'm bringing this up so > you can decide for yourself based on examples from the past > > here are a few examples: > - when Kevin upstreamed the MMC driver for GX he decided to use > MMC_MESON_GX for the Kconfig symbol name. it turns out that this is > smart because there are at least two other MMC controller IPs on the > 32-bit SoCs. due to him including GX in the name the drivers are easy > to differentiate (MMC_MESON_MX_SDIO and MMC_MESON_MX_SDHC being the > other ones, while the latter is not upstream yet) > - when Carlo upstreamed the eFuse driver he decided to use MESON_EFUSE > for the Kconfig symbol name. I found out much later that the 32-bit > SoCs use a different IP (or at least direct register access instead of > going through Secure Monitor). the driver for the 32-bit SoCs now uses > MESON_MX_EFUSE. if you don't know which driver applies where then it's > easy to mix up MESON_EFUSE and MESON_MX_EFUSE > - when Jerome upstreamed the ALSA driver for AXG (which is also used > on G12A and G12B) he decided to use the SND_MESON_AXG_* prefix for the > Kconfig symbol names. in my opinion this was a good choice because GXM > and everything earlier (including the 32-bit SoCs) use a different > audio IP block. we won't have a Kconfig symbol name clash when a > driver for the "older" SoCs is upstreamed > - (there are more examples, Meson8b USB PHY driver, Meson8b DWMAC > glue, ... - just like there's many examples where the IP block is > mostly compatible with older generations: SAR ADC, RNG, SPI, ...) While these are all good examples, you can see it can go both ways, so there's really no way know up front what is the "right" way. We only know after the fact. Unfortunately, we simply have no visibility into future chips and where IP blocks may be shared or not (there are other examples where vendors add a new version of an IP *and* keep the old version. ;) Even having worked inside a (different) SoC vendor and having some knowledge about what IPs are shared, it's difficult to get this right. > I'm not sure what driver naming rules other mainline SoC teams use > to me it seems that the rule for Allwinner driver names is to use the > "code-name of the first SoC the IP block appeared in" That's a good rule of thumb (and one we generally follow) but I don't feel it's important enough to enforce strictly either. Kevin
