On Sat 2014-03-29 01:31:47, Sebastian Reichel wrote: > The Nokia N900's modem is connected via Synchronous Serial Interface (SSI), > which is a legacy version of MIPI's High-speed Synchronous Serial Interface > (HSI). > > The handles the GPIOs for enabling and resetting the modem and instanciates > ssi-protocol for data exchange. It does not yet support exchanging voice data > with the modem. > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> Reviewed-by: Pavel Machek <pavel@xxxxxx> > +static void do_nokia_modem_rst_ind_tasklet(unsigned long data) > +{ > + struct nokia_modem_device *modem = (struct nokia_modem_device *)data; > + > + if (!modem) > + return; > + > + dev_info(modem->device, "*** CMT rst line change detected ***\n"); Maybe slightly less stars would work? > +static int nokia_modem_gpio_probe(struct device *dev) > +{ > + struct device_node *np = dev->of_node; > + struct nokia_modem_device *modem = dev_get_drvdata(dev); > + int gpio_count, gpio_name_count, i, err; > + > + gpio_count = of_gpio_count(np); > + gpio_name_count = of_property_count_strings(np, "gpio-names"); > + > + if(gpio_count != gpio_name_count) { "if (". > + modem->ssi_protocol = hsi_new_client(port, &ssip); > + if (modem->ssi_protocol == NULL) { ...if (! ...) > + dev_err(dev, "Could not register ssi-protocol device\n"); > + goto error2; > + } > + > + err = device_attach(&modem->ssi_protocol->device); > + if (err == 0) { if (!...) Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html