On Tue, Aug 6, 2019 at 2:50 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > Now that we have the DT validation in place, let's convert the device tree > bindings for the Synopsys DWMAC Glue for Amlogic SoCs over to a YAML schemas. > > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> thank you for taking care of this conversion! Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> [...] > + amlogic,tx-delay-ns: > + $ref: /schemas/types.yaml#definitions/uint32 > + description: > + The internal RGMII TX clock delay (provided by this driver) in > + nanoseconds. Allowed values are 0ns, 2ns, 4ns, 6ns. once I have more time I will try to see whether we can define an enum with these values, then invalid values will yield a warning/error when building the .dtb (which seems to be a good idea) this comment shouldn't prevent this patch from being applied as the initial conversion will already make life a lot easier Martin
