On Mon, 2019-08-05 at 16:27 +0200, Andrew Lunn wrote: > [External] > > On Mon, Aug 05, 2019 at 07:54:53PM +0300, Alexandru Ardelean wrote: > > This change adds bindings for the Analog Devices ADIN PHY driver, detailing > > all the properties implemented by the driver. > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > --- > > .../devicetree/bindings/net/adi,adin.yaml | 93 +++++++++++++++++++ > > MAINTAINERS | 2 + > > include/dt-bindings/net/adin.h | 26 ++++++ > > 3 files changed, 121 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/adi,adin.yaml > > create mode 100644 include/dt-bindings/net/adin.h > > > > diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml > > b/Documentation/devicetree/bindings/net/adi,adin.yaml > > new file mode 100644 > > index 000000000000..fcf884bb86f7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml > > @@ -0,0 +1,93 @@ > > +# SPDX-License-Identifier: GPL-2.0+ > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/adi,adin.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices ADIN1200/ADIN1300 PHY > > + > > +maintainers: > > + - Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > + > > +description: | > > + Bindings for Analog Devices Industrial Ethernet PHYsphy > > + > > +properties: > > + compatible: > > + description: | > > + Compatible list, may contain "ethernet-phy-ieee802.3-c45" in which case > > + Clause 45 will be used to access device management registers. If > > + unspecified, Clause 22 will be used. Use this only when MDIO supports > > + Clause 45 access, but there is no other way to determine this. > > + enum: > > + - ethernet-phy-ieee802.3-c45 > > It is valid to list ethernet-phy-ieee802.3-c22, it is just not > required. So maybe you should list it here to keep the DT validater happy? ack > > Andrew