On Sat 03 Aug 07:20 PDT 2019, Brian Masney wrote: > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > new file mode 100644 > index 000000000000..7c28ad3108a6 > --- /dev/null > +++ b/drivers/soc/qcom/ocmem.c > @@ -0,0 +1,433 @@ > +// SPDX-License-Identifier: GPL-2.0-only [..] > +MODULE_LICENSE("GPL"); Shouldn't this be "GPL v2"? Apart from that I think this looks good. Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> @Rob, would you like to take this series through your tree or would you lend me an Ack on the adreno patch and I'll apply it through the qcom tree? Feel free to add my Acked-by to the relevant patches, if needed. Regards, Bjorn