On Fri, Aug 2, 2019 at 8:37 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > Hi Rob, > > Thanks for reviews. > > On 01/08/2019 15:56, Neil Armstrong wrote: > > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > > --- > > .../amlogic/amlogic,meson-gx-ao-secure.txt | 28 ------------- > > .../amlogic/amlogic,meson-gx-ao-secure.yaml | 42 +++++++++++++++++++ > > 2 files changed, 42 insertions(+), 28 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt > > create mode 100644 Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt > > deleted file mode 100644 > > index c67d9f48fb91..000000000000 > > --- a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt > > +++ /dev/null > > @@ -1,28 +0,0 @@ > > -Amlogic Meson Firmware registers Interface > > ------------------------------------------- > > - > > -The Meson SoCs have a register bank with status and data shared with the > > -secure firmware. > > - > > -Required properties: > > - - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-ao-secure", "syscon" > > I have a hard time find how to define "syscon" here, if I put syscon in the compatible > it gets matched on other bindings and I get lot of warnings. > > How should I model it ? You have to add a custom 'select' key that doesn't include 'syscon'. There should be a few examples in the tree. Rob
