On Fri, Apr 18, 2014 at 05:33:51PM +0100, Mark Brown wrote:
> On Thu, Apr 17, 2014 at 05:53:10PM +0200, Andrew Lunn wrote:
>
> > + - compatible: "realtek,alc5623"
>
> You've not added an ID table to the driver for this.
The driver already has:
static const struct i2c_device_id alc5623_i2c_table[] = {
{"alc5621", 0x21},
{"alc5622", 0x22},
{"alc5623", 0x23},
{}
};
MODULE_DEVICE_TABLE(i2c, alc5623_i2c_table);
which is enough for the i2c layer to load the driver when it walks the
nodes under the i2c bus driver in the DT.
> > + - add-ctrl: Default register value for Reg-40h, Additional Control Register.
> > + If absent, the default is 0.
>
> > + - jack-det-ctrl: Default register value for Reg-5Ah, Jack Detect
> > + Control Register. If absent, the default is 0.
>
> I would expect the default for these to be to leave the hardware
> defaults untouched - why is it different, what does setting to zero mean?
The description is wrong. I will fix it. If the property is absent, or
the value is zero, the register is left alone.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
