Hi Mason, Mason Yang <masonccyang@xxxxxxxxxxx> wrote on Thu, 1 Aug 2019 11:55:10 +0800: > Document the bindings used by the Macronix raw NAND controller. > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/Documentation/devicetree/bindings/mtd/mxic-nand.txt > new file mode 100644 > index 0000000..de37d60 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt > @@ -0,0 +1,19 @@ > +Macronix Raw NAND Controller Device Tree Bindings > +------------------------------------------------- > + > +Required properties: > +- compatible: should be "mxicy,multi-itfc-v009-nand-morph" > +- reg: should contain 1 entry for the registers > +- interrupts: interrupt line connected to this raw NAND controller > +- clock-names: should contain "ps", "send" and "send_dly" > +- clocks: should contain 3 phandles for the "ps", "send" and > + "send_dly" clocks > + > +Example: > + > + nand: nand-controller@43c30000 { > + compatible = "mxicy,multi-itfc-v009-nand-morph"; "mxicy" looks strange to me, I know it has been used in the past and cannot be removed, but I don't think it is wise to continue using it while your use "mxic" in all your other contributions. I would update the prefix to mxic here and fill-in the relevant doc. Also, what is nand-morph? I thought we were okay for the "-nand-controller" suffix. Thanks, Miquèl