Hi, On Wed, Jul 31, 2019 at 11:43:47AM -0300, Fabio Estevam wrote: > Hi Guido, > > On Wed, Jul 31, 2019 at 11:35 AM Guido Günther <agx@xxxxxxxxxxx> wrote: > > > The idea is to have > > > > "%sabling platform clocks", enable ? "en" : "dis"); > > > > depending whether clocks are enabled/disabled. > > Yes, I understood the idea, but this would print: > > ensabling or dissabling :-) The 's' is from the '%s' format specifier: [ 2610.804174] imx-nwl-dsi 30a00000.mipi_dsi: [drm:imx_nwl_dsi_bridge_disable] disabling platform clocks [ 2710.996279] imx-nwl-dsi 30a00000.mipi_dsi: [drm:imx_nwl_dsi_bridge_pre_enable] enabling platform clocks I'll change that to use the full strings though since i also had to look twice to be sure there's no double 's'. > > > > Same here. Please return 'int' instead. > > > > This is from drm_bridge_funcs so the prototype is fixed. I'm not sure > > how what's the best way to bubble up fatal errors through the drm layer? > > Ok, so let's not change this one. > > > I went for DRM_DEV_ERROR() since that what i used in the rest of the > > driver and these ones were omission. Hope that's o.k. > > No strong preferences here. I just think dev_err() easier to type and shorter. > > Thanks for this work! Thanks again for having a look! -- Guido
