Hi Lukasz, On Tue, Jul 30, 2019 at 6:48 PM Lukasz Majewski <lukma@xxxxxxx> wrote: > > Before this change the device tree description of qspi node for > second memory on BK4 board was wrong (applicable to old, removed > fsl-quadspi.c driver). > > As a result this memory was not recognized correctly when used > with the new spi-fsl-qspi.c driver. > > From the dt-bindings: > > "Required SPI slave node properties: > - reg: There are two buses (A and B) with two chip selects each. > This encodes to which bus and CS the flash is connected: > <0>: Bus A, CS 0 > <1>: Bus A, CS 1 > <2>: Bus B, CS 0 > <3>: Bus B, CS 1" > > According to above with new driver the second SPI-NOR memory shall > have reg=<2> as it is connected to Bus B, CS 0. > > Signed-off-by: Lukasz Majewski <lukma@xxxxxxx> > Suggested-by: Fabio Estevam <festevam@xxxxxxxxx> > Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device > (vf610 based)") Please fix the order of the tags. - Fixes tag goes first (do not split it into two lines) - Suggested-by - Your Signed-off-by With these changes you can add as the last tag: Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>