Re: [PATCH 12/22] ARM: dts: imx6: Add touchscreens used on Toradex eval boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31. 07. 19 8:43, Philippe Schenker wrote:
On Tue, 2019-07-30 at 17:46 -0300, Fabio Estevam wrote:
On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker <dev@xxxxxxxxxxxx> wrote:

+       /* Atmel maxtouch controller */
+       atmel_mxt_ts: atmel_mxt_ts@4a {

Generic node names, please:

touchscreen@4a

+               compatible = "atmel,maxtouch";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_pcap_1>;
+               reg = <0x4a>;
+               interrupt-parent = <&gpio1>;
+               interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* SODIMM 28 */
+               reset-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; /* SODIMM 30 */
+               status = "disabled";
+       };
+
+       /*
+        * the PCAPs use SODIMM 28/30, also used for PWM<B>, PWM<C>, aka
pwm1,
+        * pwm4. So if you enable one of the PCAP controllers disable the
pwms.
+        */
+       pcap: pcap@10 {

touchscreen@10

+               /* TouchRevolution Fusion 7 and 10 multi-touch controller */
+               compatible = "touchrevolution,fusion-f0710a";

I do not find this binding documented.

Thanks for your feedback Fabio, and sorry such obvious stuff went through. I
will go through my whole patchset again more carefully lookup all the bindings.

Hi Philippe,
also look at the I2C sub-nodes - they should be sorted by the bus address.
In most of the patches it is not correct.

Michal



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux