On 30/07/2019 10:04, Jerome Brunet wrote:
On Mon 29 Jul 2019 at 19:39, Carlo Caione <ccaione@xxxxxxxxxxxx> wrote:
/cut
+struct meson_efuse { + struct nvmem_device *nvmem; + struct nvmem_config config; + struct clk *clk;since this driver uses devm_add_action_or_reset, I don't think you need to keep the clk pointer around, unless you plan to do something with it later on ?
Good point about the clk pointer.
It is kind of the same the other structure members, do we need to keep them around ? We could just let devm deal with it ? If you have a plan, could you share it ?
No plan. In the PATCH 4/5 I was going to add struct meson_sm_firmware to the bundle and to me it's a bit more elegant to have all the auxiliary structs together in a single container.
For the sake of keeping the diff size low I'm going to rework this in V2. -- Carlo Caione
