On Mon 29 Jul 2019 at 19:39, Carlo Caione <ccaione@xxxxxxxxxxxx> wrote: > No need to be a global struct. > > Signed-off-by: Carlo Caione <ccaione@xxxxxxxxxxxx> Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > --- > drivers/firmware/meson/meson_sm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c > index 8d908a8e0d20..772ca6726e7b 100644 > --- a/drivers/firmware/meson/meson_sm.c > +++ b/drivers/firmware/meson/meson_sm.c > @@ -35,7 +35,7 @@ struct meson_sm_chip { > struct meson_sm_cmd cmd[]; > }; > > -struct meson_sm_chip gxbb_chip = { > +static const struct meson_sm_chip gxbb_chip = { > .shmem_size = SZ_4K, > .cmd_shmem_in_base = 0x82000020, > .cmd_shmem_out_base = 0x82000021, > -- > 2.20.1