On Thu, Jun 27, 2019 at 11:32 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > The phy device tree property has been deprecated in favor of phy-handle, > let's replace it. > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx> This patch breaks Ethernet on all my dwmac-sunxi, i.e. old GMAC, boards, with the following error messages: sun7i-dwmac 1c50000.ethernet eth0: no phy at addr -1 sun7i-dwmac 1c50000.ethernet eth0: stmmac_open: Cannot attach to PHY (error: -19) Reverting this patch fixes it. It also breaks the A10/A10s, but that's probably because the sun4i-emac driver doesn't recognize the "phy-handle" property. ChenYu