On Mon, Jul 29, 2019 at 11:15 PM Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote: > > On Sun, Jul 28, 2019 at 10:24:26PM +0300, Daniel Baluta wrote: > > SAI supports up to 8 data lines. This property let the user > > configure how many data lines should be used per transfer > > direction (Tx/Rx). > > This sounds a bit less persuasive to me as we are adding a > DT property that's used to describe a hardware connections > and it would be probably better to mention that the mapping > between the mask and the data lines could be more flexible > than consecutive active data lines as you said previously. > > > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx> > > --- > > Documentation/devicetree/bindings/sound/fsl-sai.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > index 2e726b983845..2b38036a4883 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > @@ -49,6 +49,13 @@ Optional properties: > > > > - big-endian : Boolean property, required if all the SAI > > registers are big-endian rather than little-endian. > > + - fsl,dl-mask : list of two integers (bitmask, first for RX, second > > I am leaving this naming to DT maintainer. > > > + for TX) representing enabled datalines. Bit 0 > > + represents first data line, bit 1 represents second > > + data line and so on. Data line is enabled if > > + corresponding bit is set to 1. By default, if property > > + not present, only dataline 0 is enabled for both > > + directions. > > To make this patch more convincing, could we add an example > as well in the Example section of this binding file? Like: > /* RX data lines 0/1 and TX data lines 0/2 are connected */ > fsl,dl-mask = <0x3 0x5>; Sure, will add an example.
