>-----Original Message----- >From: netdev-owner@xxxxxxxxxxxxxxx <netdev-owner@xxxxxxxxxxxxxxx> On >Behalf Of Claudiu Manoil >Sent: Monday, July 29, 2019 6:40 PM >To: Andrew Lunn <andrew@xxxxxxx> >Cc: David S . Miller <davem@xxxxxxxxxxxxx>; Rob Herring ><robh+dt@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Alexandru Marginean ><alexandru.marginean@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; >devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx >Subject: RE: [PATCH net-next v3 2/4] enetc: Add mdio bus driver for the PCIe >MDIO endpoint > >>-----Original Message----- >>From: Andrew Lunn <andrew@xxxxxxx> >>Sent: Monday, July 29, 2019 6:35 PM >>To: Claudiu Manoil <claudiu.manoil@xxxxxxx> >>Cc: David S . Miller <davem@xxxxxxxxxxxxx>; Rob Herring >><robh+dt@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Alexandru Marginean >><alexandru.marginean@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; >>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; >>linux- kernel@xxxxxxxxxxxxxxx >>Subject: Re: [PATCH net-next v3 2/4] enetc: Add mdio bus driver for the >>PCIe MDIO endpoint >> >>> + hw->port = pci_iomap(pdev, 0, 0); >>> + if (!bus->priv) { >> >>hw->port ?? >> > >Yeah, better ignore this for now 😊 >It's for the enetc accessors, enetc_port_..(). Oh I see, it's a mistake. I'm checking the wrong thing. Sorry. Thanks for the review.