On Sun, Jul 28, 2019 at 5:53 PM Angus Ainslie <angus@xxxxxxxx> wrote:
>
> Hi Daniel,
>
> On 2019-07-28 07:12, Daniel Baluta wrote:
> > From: Abel Vesa <abel.vesa@xxxxxxx>
> >
> > Add the initial configuration for clocks that need default parent and
> > rate
> > setting. This is based on the vendor tree clock provider parents and
> > rates
> > configuration except this is doing the setup in dts rather then using
> > clock
> > consumer API in a clock provider driver.
> >
> > Note that by adding the initial rate setting for audio_pll1/audio_pll
> > setting we need to remove it from imx8mq-librem5-devkit.dts
> > imx8mq-librem5-devkit.dts
> >
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
>
> This works with our board. One small nit below
>
> Tested-by: Angus Ainslie (Purism) <angus@xxxxxxxx>
>
> > ---
> > Changes since v2:
> > - set rate for audio_pll1/audio_pll2 in the dtsi file and
> > remove the setting from imx8mq-librem5-devkit.dts
> >
> > .../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
> > 2 files changed, 21 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..c702ccc82867 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -169,11 +169,6 @@
> > };
> > };
> >
> > -&clk {
> > - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
> > - assigned-clock-rates = <786432000>, <722534400>;
> > -};
> > -
> > &dphy {
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 02fbd0625318..c67625a881a4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -494,6 +494,27 @@
> > clock-names = "ckil", "osc_25m", "osc_27m",
> > "clk_ext1", "clk_ext2",
> > "clk_ext3", "clk_ext4";
> > + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL2>,
> > + <&clk IMX8MQ_CLK_AHB>,
> > + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> > + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> > + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> > + <&clk IMX8MQ_CLK_NOC>;
> > + assigned-clock-parents = <0>,
> > + <0>,
> > + <0>,
> > + <&clk IMX8MQ_SYS1_PLL_133M>,
> > + <&clk IMX8MQ_SYS1_PLL_266M>,
> > + <&clk IMX8MQ_SYS2_PLL_500M>,
> > + <&clk IMX8MQ_CLK_27M>,
> > + <&clk IMX8MQ_SYS1_PLL_800M>;
> > + assigned-clock-rates = <593999999>,
> > + <786432000>,
> > + <722534400>;
> > +
> > +
>
> Extra whitespace
Thanks Angus for testing. Fixed in v4.
