On 17/04/14 15:08, Laurent Pinchart wrote:
>>>> static struct i2c_driver adv7604_driver = {
>>>> > > >
>>>> > > > .driver = {
>>>> > > >
>>>> > > > .owner = THIS_MODULE,
>>>> > > > .name = "adv7604",
>>>> > > >
>>>> > > > + .of_match_table = of_match_ptr(adv7604_of_id),
>>> > >
>>> > > of_match_ptr() isn't necessary here.
>> >
>> > Thanks, will fix in v3.
>
> On second thought, as the driver has non-DT users, keeping of_match_ptr() and
> marking the table as __maybe_unused will optimize the table out if neither
> CONFIG_OF nor CONFIG_MODULE is set. I'd thus prefer keeping of_match_ptr().
Yes, itsounds like a good idea to me. This way we avoid unpleasant #ifdefs
and do not increase size of the module for non-dt users.
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
