Hi Miquel, Thanks for this, I gave it a quick test and it looks good. On Thu, 27 Jun 2019 11:50:48 +0200 Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: >From: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx> > >Keep the exact same list of supported configurations but first try to >use the firmware's implementation. If it fails, try the legacy method: >Linux implementation. > >Signed-off-by: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx> >[miquel.raynal@xxxxxxxxxxx: adapt the content to the mainline driver] >Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> [...] >+ dev_warn(priv->dev, >+ "Firmware could not configure PHY %d with mode %d (ret: %d), trying legacy method\n", >+ ret, lane->id, lane->mode); Small nit, you've got your parameters in the wrong order in that dev_warn. Besides that, Tested-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
