Re: [PATCH] iio: potentiometer: add a driver for Maxim 5432-5435

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.3-rc1 next-20190722]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Martin-Kaiser/iio-potentiometer-add-a-driver-for-Maxim-5432-5435/20190723-024214
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/iio/potentiometer/max5432.c: In function 'max5432_probe':
>> drivers/iio/potentiometer/max5432.c:99:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     data->ohm = (u32)of_device_get_match_data(dev);
                 ^

vim +99 drivers/iio/potentiometer/max5432.c

    83	
    84	static int max5432_probe(
    85			struct i2c_client *client, const struct i2c_device_id *id)
    86	{
    87		struct device *dev = &client->dev;
    88		struct iio_dev *indio_dev;
    89		struct max5432_data *data;
    90	
    91		indio_dev = devm_iio_device_alloc(dev, sizeof(struct max5432_data));
    92		if (!indio_dev)
    93			return -ENOMEM;
    94	
    95		i2c_set_clientdata(client, indio_dev);
    96	
    97		data = iio_priv(indio_dev);
    98		data->client = client;
  > 99		data->ohm = (u32)of_device_get_match_data(dev);
   100	
   101		indio_dev->dev.parent = dev;
   102		indio_dev->info = &max5432_info;
   103		indio_dev->channels = max5432_channels;
   104		indio_dev->num_channels = ARRAY_SIZE(max5432_channels);
   105		indio_dev->name = client->name;
   106	
   107		return devm_iio_device_register(dev, indio_dev);
   108	}
   109	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux