Re: [PATCH 4/5] arm64: dts: qcom: sdm845: remove macro from unit name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22-07-19, 15:18, Marc Gonzalez wrote:
> On 22/07/2019 14:34, Vinod Koul wrote:
> 
> > Unit name is supposed to be a number, using a macro with hex value is
> > not recommended, so add the value in unit name.
> > 
> > arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x"
> > arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s
> > 
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > index 051a52df80f9..d76c8377c224 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > @@ -78,7 +78,7 @@
> >  			#size-cells = <0>;
> >  			#io-channel-cells = <1>;
> >  
> > -			adc-chan@ADC5_DIE_TEMP {
> > +			adc-chan@6{
> 
> You dropped the space before the {

Oops, will fix it up, thanks for pointing!

-- 
~Vinod



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux