On 21.07.19 16:15, Arnd Bergmann wrote:
That is different: the hardware attaches to a serial port and may well be usable, and the user space side just contains a copy of the header, see https://github.com/nwdigitalradio/ax25-tools/tree/master/yamdrv
I believe that such header copies in userland applications are conceptionally wrong. Whenever something changes, both sides need to be kept in sync. Maybe we should talk to the hamradio folks to get this cleaned up. IMHO, this header should go to uapi.
It seems more useful to keep looking for drivers with a platform_data header file that is no longer included by any platform for candidates that may be obsolete.
Some folks see platform_data old legacy that should be removed, but I don't aggree. For example w/ apu2 board driver (and corresponding amd-fch-gpio driver) I even had to introduce a pdata struct, so the board driver could configure the gpio driver. Certainly, I would have preferred doing everything via DT, but that's not available on x86/acpi targets (if anybody knows a way to inject a DT snippet just for one driver in such a scenario, please let me know). --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
