On Fri, Jul 19, 2019 at 2:22 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> Hi Andra,
>
> On Fri, Jul 19, 2019 at 7:48 AM andradanciu1997
> <andradanciu1997@xxxxxxxxx> wrote:
>
> > + pmic: pmic@4b {
> > + reg = <0x4b>;
> > + compatible = "rohm,bd71837";
> > + /* PMIC BD71837 PMIC_nINT GPIO1_IO12 */
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_pmic>;
> > + clocks = <&pmic_osc>;
> > + clock-names = "osc";
> > + clock-output-names = "pmic_clk";
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <3 GPIO_ACTIVE_LOW>;
> > + interrupt-names = "irq";
> > +
> > + regulators {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> #address-cells and #size-cells are not needed and they cause warnings with W=1:
>
> DTC arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb
> arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts:77.14-196.5: Warning
> (avoid_unnecessary_addr_size):
> /soc@0/bus@30800000/i2c@30a20000/pmic@4b/regulators: unnecessary
> #address-cells/#size-cells without "ranges" or child "reg" property
>
> Please remove them.
Thanks Fabio for review, we learned something new today :).
Daniel.
