On Thu, Jul 18, 2019 at 9:40 PM Leonard Crestez <leonard.crestez@xxxxxxx> wrote: > > On 18.07.2019 21:24, Daniel Baluta wrote: > > On Thu, Jul 18, 2019 at 7:41 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > >> > >> On Thu, Jul 18, 2019 at 9:13 AM Daniel Baluta <daniel.baluta@xxxxxxx> wrote: > >>> > >>> This describes the DSP device tree node. > >>> > >>> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx> > > >>> + power-domains: > >>> + description: > >>> + List of phandle and PM domain specifier as documented in > >>> + Documentation/devicetree/bindings/power/power_domain.txt > >> > >> How many? 4? > > > > Yes, 4 for i.MX8QXP. Also, the same number is for i.MX8QM. Anyhow, I didn't > > added added a limit here because I really don't know how many will be > > in upcoming i.MX platforms. > > Which 4? It might help to use power-domain-names explicitly just like > it's done for clocks and mboxes. > > This is very common for phandle lists. 4 like in the example at the bottom of the patch: + power-domains = <&pd IMX_SC_R_MU_13A>, + <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_DSP>, + <&pd IMX_SC_R_DSP_RAM>; Not sure if it makes sense to use power-domain-names as the driver parses directly the "power-domains" property.