On Thu 18 Jul 08:31 PDT 2019, Mathieu Poirier wrote: > On Wed, 17 Jul 2019 at 23:47, Sai Prakash Ranjan > <saiprakash.ranjan@xxxxxxxxxxxxxx> wrote: > > > > Hi Mathieu, > > > > On 7/17/2019 10:30 PM, Mathieu Poirier wrote: > > > On Fri, Jul 12, 2019 at 07:46:25PM +0530, Sai Prakash Ranjan wrote: > > >> From: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx> > > >> > > >> Enable coresight support by adding device nodes for the > > >> available source, sinks and channel blocks on msm8996. > > >> > > >> This also adds coresight cpu debug nodes. > > >> > > >> Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx> > > >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx> > > >> Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> > > >> Acked-By: Suzuki K Poulose <suzuki.poulose@xxxxxxx> > > >> --- > > >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 434 ++++++++++++++++++++++++++ > > >> 1 file changed, 434 insertions(+) > > >> > > > > > > We've gone trhough 8 iteration of this set and I'm still finding checkpatch > > > problems, and I'm not referring to lines over 80 characters. > > > > > > > I only get below 2 checkpatch warnings: > > > > If you are talking about the below one, then it was not added manually. > > It was taken automatically when I pulled in the v7. Should I be > > resending this patch for this? > > That depends if you want David and Andy to pickup your patches - I am > sure they'll point out exactly the same thing. > If it's only the capitalization of "By" then I'll just fix it up as I apply the patches (thanks for pointing it out though!). But it seems the discussion on patch 2 needs to settle(?) (And the merge window has to close). Regards, Bjorn > > > > $ ./scripts/checkpatch.pl -g 2fa725fbc09306f1a95befc62715a708b4c0fad0 > > WARNING: 'Acked-by:' is the preferred signature form > > #14: > > Acked-By: Suzuki K Poulose <suzuki.poulose@xxxxxxx> > > > > WARNING: line over 80 characters > > #154: FILE: arch/arm64/boot/dts/qcom/msm8996.dtsi:763: > > + compatible = "arm,coresight-dynamic-replicator", > > "arm,primecell"; > > > > total: 0 errors, 2 warnings, 440 lines checked > > > > > > -Sai > > > > -- > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > > of Code Aurora Forum, hosted by The Linux Foundation
