Hi, Yongqiang: On Tue, 2019-07-09 at 06:33 +0800, yongqiang.niu@xxxxxxxxxxxx wrote: > From: Yongqiang Niu <yongqiang.niu@xxxxxxxxxxxx> > > Update device tree binding documention for the display subsystem for > Mediatek MT8183 SOCs > > Signed-off-by: Yongqiang Niu <yongqiang.niu@xxxxxxxxxxxx> > --- > .../bindings/display/mediatek/mediatek,display.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,display.txt > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,display.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,display.txt > new file mode 100644 > index 0000000..951d2a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,display.txt > @@ -0,0 +1,21 @@ > +Mediatek Display Device > +============================ > + > +The Mediatek Display Device provides power control to the system. > + > +Required Properties: > + > +- compatible: Should be one of: > + - "mediatek,mt8183-display" I think this is "mediatek,mt8183-mmsys". In [1], Matthias has agreed that we could keep work on his patch, so you should apply his patch and remove this patch. In [2], I've found that MT8183 scpsys has some problem with Matthias' patch, so please also fix this problem. [1] https://patchwork.kernel.org/patch/10686327/ [2] https://patchwork.kernel.org/patch/11005731/ Regards, CK > + > +The Display Device power name are defined in > +include\dt-bindings\power\mt*-power.h > + > + > +Example: > + > +display_components: dispsys@14000000 { > + compatible = "mediatek,mt8183-display"; > + reg = <0 0x14000000 0 0x1000>; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > +}; > \ No newline at end of file
