On Tue, 16 Jul 2019, at 08:47, Joel Stanley wrote: > On Mon, 15 Jul 2019 at 22:37, Rob Herring <robh@xxxxxxxxxx> wrote: > > > > The Aspeed pinctl schema have errors in the 'compatible' schema: > > > > Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml: \ > > properties:compatible:enum: ['aspeed', 'ast2400-pinctrl', 'aspeed', 'g4-pinctrl'] has non-unique elements > > Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml: \ > > properties:compatible:enum: ['aspeed', 'ast2500-pinctrl', 'aspeed', 'g5-pinctrl'] has non-unique elements > > > > Flow style sequences have to be quoted if the vales contain ','. Fix > > this by using the more common one line per entry formatting. > > > > > properties: > > compatible: > > - enum: [ aspeed,ast2400-pinctrl, aspeed,g4-pinctrl ] > > + enum: > > + - aspeed,ast2400-pinctrl > > + - aspeed,g4-pinctrl > > Thanks for the fix. However, we've standardised on the first form for > all of our device trees, so we can drop the second compatible string > from the bindings. > > I think Andrew already has a patch cooking to do this. Yes, I have a series in the works. Will send patches soon. Andrew
