On 15/07/2019 18:15:19+0800, Biwen Li wrote: > + device_init_wakeup(&pdev->dev, true); > + rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, "ftm-alarm", > + &ftm_rtc_ops, > + THIS_MODULE); To be clear, I want you to not use devm_rtc_device_register and use devm_rtc_allocate_device and rtc_register_device. > + if (IS_ERR(rtc->rtc_dev)) { > + dev_err(&pdev->dev, "can't register rtc device\n"); > + return PTR_ERR(rtc->rtc_dev); > + } > + -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com