RE: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI audio support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 12 July 2019 14:42
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI audio support
> 
> Hi Fabrizio,
> 
> On Fri, Jul 5, 2019 at 3:40 PM Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > This patch adds support for HDMI audio to the device tree
> > common to the HiHope RZ/G2M and the HiHope RZ/G2N.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> 
> > @@ -168,6 +180,7 @@
> >
> >  &hdmi0 {
> >         status = "okay";
> > +       #sound-dai-cells = <0>;
> 
> Why the above line?

It doesn't belong there, good catch, I'll send a v2 shortly without it.

Thanks,
Fab

> 
> With the above question answered:
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux