Hi Richard, On Wed, Apr 16, 2014 at 7:03 PM, Richard Genoud <richard.genoud@xxxxxxxxx> wrote: > Hi Vivek, > > 2014-04-09 13:34 GMT+02:00 Vivek Gautam <gautam.vivek@xxxxxxxxxxx>: >> Hi Tomasz, >> ' >> >> On Wed, Apr 9, 2014 at 4:43 PM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: >>> Hi Vivek, >>> >> Thanks for reviewing the patch series. >> >>> >>> On 08.04.2014 16:36, Vivek Gautam wrote: >>>> >>>> Removing this older USB 3.0 DRD controller PHY driver, since >>>> a new driver based on generic phy framework is now available. >>>> >>>> Also removing the dt node for older driver from Exynos5250 >>>> device tree and updating the dt node for DWC3 controller. >>>> >>>> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> >>>> --- >>>> >>>> NOTE: This patch should be merged only when the new USB 3.0 >>>> DRD phy controller driver is available in the tree from the >>>> patches: >>>> phy: Add new Exynos5 USB 3.0 PHY driver; and >>>> dt: exynos5250: Enable support for generic USB DRD phy >>>> >>>> arch/arm/boot/dts/exynos5250.dtsi | 17 +- >>>> drivers/usb/phy/phy-samsung-usb.h | 83 --------- >>>> drivers/usb/phy/phy-samsung-usb3.c | 350 >>>> ------------------------------------ >>>> 3 files changed, 2 insertions(+), 448 deletions(-) >>>> delete mode 100644 drivers/usb/phy/phy-samsung-usb3.c >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >>>> b/arch/arm/boot/dts/exynos5250.dtsi >>>> index 92c6fcd..1cb1e91 100644 >>>> --- a/arch/arm/boot/dts/exynos5250.dtsi >>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi >>> >>> >>> IMHO driver and dts changes should be separated into two patches, first >>> updating device tree to use the new driver and second removing the driver. >> >> Sure will separate the patch into driver and dts change. >> >>> >>> After fixing this issue, >>> >>> Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> >>> > I guess you should also remove phy-samsung-usb3.c references in the > Makefile, Kconfig and exynos_defconfig You are correct. In fact i identified this issue once i submitted the patch :-( I have amended the things in my next series which i will be posting soon. Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
