On Mon, 8 Jul 2019 at 16:12, <k.konieczny@xxxxxxxxxxxxxxxxxxx> wrote: > > From: Kamil Konieczny <k.konieczny@xxxxxxxxxxxxxxxxxxx> > > Hi, > > The main purpose of this patch series is to add coupled regulators for > Exynos5422/5800 to keep constrain on voltage difference between vdd_arm > and vdd_int to be at most 300mV. In exynos-bus instead of using > regulator_set_voltage_tol() with default voltage tolerance it should be > used regulator_set_voltage_triplet() with volatege range, and this is > already present in opp/core.c code, so it can be reused. While at this, > move setting regulators into opp/core. > > This patchset was tested on Odroid XU3. > > The last patch depends on two previous. So you break the ABI... I assume that patchset maintains bisectability. However there is no explanation why ABI break is needed so this does not look good... Best regards, Krzysztof > > Regards, > Kamil > > Kamil Konieczny (2): > opp: core: add regulators enable and disable > devfreq: exynos-bus: convert to use dev_pm_opp_set_rate() > > Marek Szyprowski (1): > ARM: dts: exynos: add initial data for coupled regulators for > Exynos5422/5800 > > arch/arm/boot/dts/exynos5420.dtsi | 34 ++-- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 4 + > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 + > arch/arm/boot/dts/exynos5800.dtsi | 32 ++-- > drivers/devfreq/exynos-bus.c | 172 +++++++----------- > drivers/opp/core.c | 13 ++ > 6 files changed, 120 insertions(+), 139 deletions(-) > > -- > 2.22.0 >