On 2019/7/9 17:35, Sergei Shtylyov wrote: > Hello! > > On 09.07.2019 6:31, Jiangfeng Xiao wrote: > >> HI13X1_GMAC delete request for soft reset at first, >> otherwise, the subsequent initialization will not >> take effect. >> >> Signed-off-by: Jiangfeng Xiao <xiaojiangfeng@xxxxxxxxxx> >> --- >> drivers/net/ethernet/hisilicon/hip04_eth.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c >> index fe61b01..19d8cfd 100644 >> --- a/drivers/net/ethernet/hisilicon/hip04_eth.c >> +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c > [...] >> @@ -853,6 +867,15 @@ static int hip04_mac_probe(struct platform_device *pdev) >> goto init_fail; >> } >> +#if defined(CONFIG_HI13X1_GMAC) >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> + priv->sysctrl_base = devm_ioremap_resource(d, res); > > There's devm_platform_ioremap_resource() now. Thank you for your review, Great issue, which makes my code more concise. I will fix it in v3. Or submit a patch to modify it separately, if maintainer applies this patch series.
