On Tue, Jul 9, 2019 at 4:33 AM Luis de Oliveira <Luis.Oliveira@xxxxxxxxxxxx> wrote: > > Hi Rob, > > Thank you for the comments, > > From: Rob Herring <robh@xxxxxxxxxx> > Date: Tue, Jul 09, 2019 at 02:52:20 > > > On Thu, Jun 06, 2019 at 05:36:28PM +0200, Luis Oliveira wrote: > > > This adds documentation of device tree bindings for the > > > DesignWare IP reset controller. > > > > > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx> > > > Signed-off-by: Luis Oliveira <luis.oliveira@xxxxxxxxxxxx> > > > --- > > > Changelog > > > - Add active low configuration example > > > - Fix compatible string in the active high example > > > > > > .../devicetree/bindings/reset/snps,dw-reset.txt | 30 ++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > > > > diff --git a/Documentation/devicetree/bindings/reset/snps,dw-reset.txt b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > new file mode 100644 > > > index 0000000..85f3301 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > @@ -0,0 +1,30 @@ > > > +Synopsys DesignWare Reset controller > > > +======================================= > > > + > > > +Please also refer to reset.txt in this directory for common reset > > > +controller binding usage. > > > + > > > +Required properties: > > > + > > > +- compatible: should be one of the following. > > > + "snps,dw-high-reset" - for active high configuration > > > + "snps,dw-low-reset" - for active low configuration > > > > This is really a standalone block? > > > > Are there versions of IP? > > > > We use this block because is is very simple. The Verilog is autogenerated > after an simple input configuration (APB config, reset pin number, active > high/low, etc) so it does not need versioning. > We use it in almost all our testchips and prototyping, and it is a > standalone block. Okay. Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
