Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc, should I publish those fixes as new patch that updates the dt-bindings or new patchset to this list?

On 7/9/2019 5:23 AM, Rob Herring wrote:
On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote:
+- #interrupt-cells: must be 2.
+  First cell defines the index of the interrupt within the controller.
+  Second cell is used to specify the trigger type and must be one of the
+  following:
+    - bits[3:0] trigger type and level flags
+	1 = low-to-high edge triggered
+	4 = active high level-sensitive
No need to define this here. Reference the standard definition.

This device only support those two modes.

This definition tries to capture the supported modes.

Should I just state that those two modes are supported and then avoid the actual bits and values?


+- interrupt-parent: specifies the parent interrupt controller.
Drop this. It is implied and could be in the parent.
ack

+- interrupts: describes which input line in the interrupt parent, this
+  fic's output is connected to. This field property depends on the parent's
+  binding
+
+Example:
+
+amazon_fic: interrupt-controller@0xfd8a8500 {
Drop the '0x'
ack



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux