On Sun, 7 Jul 2019 15:22:46 +0200
Aleix Roca Nonell <kernelrocks@xxxxxxxxx> wrote:
> Add binding for Realtek RTD129x interrupt controller.
>
> Signed-off-by: Aleix Roca Nonell <kernelrocks@xxxxxxxxx>
> ---
> .../realtek,rtd129x-intc.txt | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt
> new file mode 100644
> index 000000000000..3ebb7c02afe5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt
> @@ -0,0 +1,24 @@
> +Realtek RTD129x IRQ Interrupt Controller
> +=======================================
> +
> +Required properties:
> +
> +- compatible : Should be one of the following:
> + - "realtek,rtd129x-intc-misc"
> + - "realtek,rtd129x-intc-iso"
What does 'iso' mean in this context?
> +- reg : Specifies the address of the ISR, IER and Unmask
> + register in couples of "address length".
Are these registers actually interleaved with other stuff? What else it
in between?
> +- interrupts : Specifies the interrupt line which is mux'ed.
> +- interrupt-controller : Presence indicates the node as interrupt controller.
> +- #interrupt-cells : Shall be 1. See common bindings in interrupt.txt.
So I guess this is level only, with an unspecified polarity? No edge
interrupts?
> +
> +
> +Example:
> +
> + interrupt-controller@98007000 {
> + compatible = "realtek,rtd129x-iso-irq-mux";
It'd be good if the the example matched the rest of the documentation.
> + reg = <0x98007000 0x4 0x98007040 0x4 0x98007004 0x4>;
> + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + };
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
