On Wed, Jul 03, 2019 at 05:35:58PM -0700, Brendan Higgins wrote: > +struct kunit { > + void *priv; > + > + /* private: internal use only. */ > + const char *name; /* Read only after initialization! */ > + bool success; /* Read only after test_case finishes! */ > +}; No lock attribute above. > +void kunit_init_test(struct kunit *test, const char *name) > +{ > + spin_lock_init(&test->lock); > + test->name = name; > + test->success = true; > +} And yet here you initialize a spin lock... This won't compile. Seems you forgot to remove this line. So I guess a re-spin is better. Luis