Hi Anson, On Fri, 2019-07-05 at 00:26 +0000, Anson Huang wrote: > Hi, Philipp > > > On Thu, 2019-07-04 at 17:44 +0800, Anson.Huang@xxxxxxx wrote: > > > From: Anson Huang <Anson.Huang@xxxxxxx> > > > > > > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible > > > property and related info to support i.MX8MM. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > --- > > > Changes since V2: > > > - Add separate line for i.MX8MM in case anything different later for > > > > i.MX8MM. > > > --- > > > Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt > > > b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt > > > index 13e0951..c2489e4 100644 > > > --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt > > > +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt > > > @@ -8,6 +8,7 @@ Required properties: > > > - compatible: > > > - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon" > > > - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon" > > > + - For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", > > > > "syscon" > > > - reg: should be register base and length as documented in the > > > datasheet > > > - interrupts: Should contain SRC interrupt @@ -46,5 +47,6 @@ Example: > > > > > > > > > For list of all valid reset indices see > > > -<dt-bindings/reset/imx7-reset.h> for i.MX7 and > > > -<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ > > > +<dt-bindings/reset/imx7-reset.h> for i.MX7, > > > +<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and > > > +<dt-bindings/reset/imx8mq-reset.h> for i.MX8MM > > > > The last line is misleading, as that file contains reset indices that are invalid > > for i.MX8MM. > > What is your suggestion about this line? I would prefer to add an imx8mm-reset.h with only the existing reset bits, using the IMX8MM_RESET_ prefix. That would make it easy to spot errors in the dtsi (anything starting with IMX8MQ_ is potentially wrong). > Just NOT change it? The change is good in principle. It just should point to an imx8mm- reset.h with only the existing resets on i.MX8MM, or imx8mq-reset.h should be modified to actually make clear which resets are valid on i.MX8MM. > Or adding a new file imx8mm-reset.h but still use the IMX8MQ_RESET_ as > prefix ? I don't think you should redefine the same macros in imx8mm-reset.h. In this case using IMX8MM_RESET_ would be better. > Or keep what I changed, but adding some comments in those macros that > i.MX8MM does NOT support? That would be acceptable as well. regards Philipp
